Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0]Namespace com_contact #20911

Merged
merged 8 commits into from
Jul 9, 2018
Merged

Conversation

brianteeman
Copy link
Contributor

Namespace of frontend components. Broken down into one PR for each component so that hopefully it can now be merged more easily and without the need for daily having to resolve merge conflicts.

Namespace of frontend components. Broken down into one PR for each component so that hopefully it can now be merged more easily and without the need for daily having to resolve merge conflicts.
@@ -10,14 +10,16 @@
defined('_JEXEC') or die;

JLoader::register('ContentHelperRoute', JPATH_SITE . '/components/com_content/helpers/route.php');
use Joomla\CMS\Router\Route;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move above line 12.

@Quy
Copy link
Contributor

Quy commented Jul 6, 2018

I have tested this item ✅ successfully on b07cb0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20911.

@brianteeman
Copy link
Contributor Author

restarting drone so that hopefully the tests will not fail anymore

@laoneo laoneo merged commit 37299b4 into joomla:4.0-dev Jul 9, 2018
@laoneo laoneo added this to the Joomla 4.0 milestone Jul 9, 2018
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the ns-front-contact branch July 9, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants