[4.0] com_finder: Properly truncate the taxonomy table #20939
Merged
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tables of com_finder are properly truncated when purging the index, except for the taxonomy table. In that table everything is deleted, except for the root node. That means that deleting this data takes basically the longest, but most importantly the autoincrement value is not reset. There isn't really a reason for this, so I'm changing this to actually truncate the table and re-insert the root node each time instead.
There isn't really a way to test this, other than to see that the purge feature still works the way it did before. It rather requires a codereview.