Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Timezone field - duplicate class #20972

Closed
brianteeman opened this issue Jul 4, 2018 · 3 comments
Closed

[4.0] Timezone field - duplicate class #20972

brianteeman opened this issue Jul 4, 2018 · 3 comments

Comments

@brianteeman
Copy link
Contributor

brianteeman commented Jul 4, 2018

If you view the source of com_config you will see duplicate classes. This is invalid markup

<div class="controls"><select id="jform_offset" name="jform[offset]" class="custom-select" class="custom-select">
 
The first one comes from

$attr .= !empty($this->class) ? ' class="custom-select ' . $this->class . '"' : ' class="custom-select"';

The second one comes from

. ' name="' . $name . '"' . $attribs . ' class="custom-select">' . $options['format.eol'];

@Quy
Copy link
Contributor

Quy commented Jul 4, 2018

Related PR #20196

@brianteeman
Copy link
Contributor Author

You can see the same in other places such as the module style field

@brianteeman
Copy link
Contributor Author

Closed as a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants