[4.0]Namespace mod multilangstatus

[brianteeman]

@infograf768 Please test this PR for your issue with #21009

[infograf768]

Bravo. That was it.
Now, don't we need to also add the sql update as I did in my tentative patch?

diff --git a/administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-07-08.sql b/administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-07-08.sql
new file mode 100644
index 0000000..5ff17f1
--- /dev/null
+++ b/administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-07-08.sql
@@ -0,0 +1 @@
+UPDATE `#__extensions` SET `namespace` = 'Joomla\\Module\\Multilangstatus' WHERE `name` = 'mod_multilangstatus';
diff --git a/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2018-07-08.sql b/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2018-07-08.sql
new file mode 100644
index 0000000..5ff17f1
--- /dev/null
+++ b/administrator/components/com_admin/sql/updates/postgresql/4.0.0-2018-07-08.sql
@@ -0,0 +1 @@
+UPDATE `#__extensions` SET `namespace` = 'Joomla\\Module\\Multilangstatus' WHERE `name` = 'mod_multilangstatus';

[infograf768]

this is not indented for other core modules

[brianteeman]

Now, don't we need to also add the sql update as I did in my tentative patch?

I was waiting to see if it worked for you. Will update soon

[infograf768]

Note: I am curious to learn where in code this new setting in the xml is used when installing a clean Joomla.

[infograf768]

I have tested this item ✅ successfully on 5e03cc8

thanks.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21020.}

[infograf768]

OOps. No. the update sql are not good
It should not be
UPDATE #__extensionsSETprotected= 1 WHEREname = 'plg_extension_namespacemap';

but
UPDATE #__extensionsSETnamespace= 'Joomla\\Module\\Multilangstatus' WHEREname = 'mod_multilangstatus';

[brianteeman]

sorry - copy paste error and then forgetting to save the change

[infograf768]

OK now. One more tester.

[laoneo]

We don't need the update scripts as this is a new feature in J4.

[brianteeman]

i thought that too but look at the other update scripts - :)

maybe we should just make a tracker item to review all update scripts before release

[infograf768]

@laoneo
What would happen if the db is not updated when updating Joomla?

Also, please explain about:
I am curious to learn where in code this new setting in the xml is used when installing a clean Joomla.

[laoneo]

My bad, we need the updates.

[mbabker]

maybe we should just make a tracker item to review all update scripts before release

#16458 is already there. Though it's far enough down the list I fully expect duplicates to be opened down the line.

[brianteeman]

I just added a release blocker tag on it so it will be easier to find. I hope.

[brianteeman]

Thanks