Restrict processing of tab items to immediate children

[ryandemmer]

Summary of Changes

When creating a new tabset within an existing tabset, using JHtml::_('bootstrap.startTabSet') etc., the tab items of the new tabset will be appended to the existing "parent" tabset.

This PR changes the selector for the jQuery iterator so that only the immediate "tab-pane" children of the tab content div are targeted and not all "tab-pane" nodes in the content div.

Testing Instructions

This is difficult to test without creating a new component or heavily editing an existing one, but the issue can be seen in markup like this:

<?php echo JHtml::_('bootstrap.startTabSet', 'tabs');?>
	<?php echo JHtml::_('bootstrap.addTab', 'tabs', 'tabs-tab1', 'Tab1');?>
		<div class="row-fluid">
			<div class="tabbable tabs-left flex-column">
    			<?php echo JHtml::_('bootstrap.startTabSet', 'tabs-left1'); ?>
    				<?php echo JHtml::_('bootstrap.addTab', 'tabs-left1', 'tabs-left1-tab1', 'Left1');?>
                		<div class="row-fluid">
                    		<?php echo $this->loadTemplate('some_template'); ?>
                		</div>
            		<?php echo JHtml::_('bootstrap.endTab');?>
            	<?php echo JHtml::_('bootstrap.endTabSet'); ?>
    		</div>
		</div>
	<?php echo JHtml::_('bootstrap.endTab');?>
<?php echo JHtml::_('bootstrap.endTabSet'); ?>

Expected result

A new set of tabs is created inside the existing tabset.

Actual result

The "Left1" tab item is appended to the "tabs-tab1" set, below "Tab1"

Documentation Changes Required

None.

[houndci-bot]

Expected indentation of 8 spaces but found 4 tabs indent
Unexpected tab character no-tabs
Unexpected string concatenation prefer-template
Unexpected unnamed function func-names
Unexpected function expression prefer-arrow-callback
Missing space before function parentheses space-before-function-paren

[houndci-bot]

Expected indentation of 8 spaces but found 4 tabs indent
Unexpected tab character no-tabs
Unexpected string concatenation prefer-template
Unexpected unnamed function func-names
Unexpected function expression prefer-arrow-callback
Missing space before function parentheses space-before-function-paren

[uglyeoin]

@dgrammatiko is this still a problem in J4?

[ryandemmer]

These scripts don't appear to be available / used anymore. Closing.