Change language debug mode to allow it to show the language constants

[brianteeman]

PR for #14304

By default there is no change when debug language is enabled - but there now is an option to display either the language constant or the language value

Arguably a new feature - I will let the maintainer decide on that

[elkuku]

I have tested this item ✅ successfully on 1277199

There is an issue that debug settings are not immediately being applied so I guess testers might get confused?

Anyway - works 😉

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21691.}

[elkuku]

I'd propose to refactor this a bit, so the code is only executed when debugging - this should have a measurable impact!

if (isset($this->strings[$key]))
{
	$string = $this->strings[$key];				

	// Store debug information
	if ($this->debug)
	{
		$value = \JFactory::getApplication()->get('debug_lang_const') == 0 ? $key : $string;
		$string = '**' . $value . '**';
				
		$caller = $this->getCallerInfo();
		if (!array_key_exists($key, $this->used))
		{
			$this->used[$key] = array();
		}
		$this->used[$key][] = $caller;
	}
}

[brianteeman]

applied your changes

[elkuku]

May I politely ask a question here.. in case this get merged... will the code eventually also end up in the 4.0 branch or does this require a separate PR?

[brianteeman]

basically yes it should do as george is pushing them all up (eventually)

however as this one uses external libraries iirc it might need to be changed so he might ask you to do a specific pr as we handle those differently in j4

[elkuku]

he might ask you to do a specific pr

I'd love to do that.

Thanks!

[brianteeman]

@elkuku I have no idea what I was talking about above. You dont have to do anything. If accepted then @wilsonge will eventually merge it into j4 as well. I "think" I replied on my phone and thought you were commenting on your own pr for a new debugger

[elkuku]

You dont have to do anything.

I also love to do that 😉

Thanks for the update.

[infograf768]

Works fine, but the Save toolbar button may be an issue when switching from constant to value.

and even worse when there is a specific custom admin menu added.

[brianteeman]

That is unavoidable if someone wants this feature.

[elkuku]

I have tested this item ✅ successfully on 82fd8ed

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21691.}

[infograf768]

I suggest to add an onChange event in the form field to save and reload the page.

[brianteeman]

That would then be different to every other selector in the ui - so that would not be a good idea

[tecpromotion]

I have tested this item ✅ successfully on 82fd8ed

Tested successfully.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21691.}

[ghost]

Ready to Commit after two successful tests.

[mbabker]

I'm not going to block the merge on this but we need to update the Language class to not rely on pulling this param from the global config at all times (basically, the same way the class has a parameter to enable/disable debug mode we should have the same for this new capability).

[brianteeman]

Thanks for merging. Not sure I can do that change but I will try

[infograf768]

This created an issue when debug is on when installing Joomla
See #28913