Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0]tinyMCE - unwanted CMS Content dropdown button #21726

Closed
wants to merge 1 commit into from

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Aug 19, 2018

Pull Request for Issue #21711

Summary of Changes

CMS Content button in TinyMCE editor is only displayed when needed.

Testing Instructions

If you have a form with a "custom" editor field you see it. Otherwise edit the article form in administrator/components/com_content/forms/article.xml

  • Change buttons="true" to buttons="false" for field-name articletext
  • Open New Article
  • The CMS Content drop-down button is there with an empty drop-down list.
    44307173-06db5d80-a39e-11e8-84c8-dd56f3ab0f7a
    Example:
<field
      name="descripton" 
      type="editor" 
      ==>    buttons="false" 
      filter="JComponentHelper::filterText"
      height="200" 
     label="COM_MYCOMP_FIELD_DESCRIPPTION_LABEL"/>

Expected result

No button

Actual result

Button is there

Documentation Changes Required

N/A

cc @schnuti @dgrammatiko

This PR requires npm for testing.

@wojsmol wojsmol changed the title tinyMCE - unwanted CMS Content dropdown button [4.0]tinyMCE - unwanted CMS Content dropdown button Aug 19, 2018
@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 19, 2018

closing in favour of the #21725

@wojsmol wojsmol closed this Aug 19, 2018
@wojsmol wojsmol deleted the 21711-fix-tiny-button branch August 19, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants