HTMLHelper stylesheet method #21734
Closed
HTMLHelper stylesheet method #21734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21216 .
Summary of Changes
In ./libraries/src/HTML/HTMLHelper.php at line 610 it writes:
if (!is_array($attribs))but should better be
if (!is_array($attribs) || !is_array($options))Reason
An old extension adding stylesheets the (very) old way like
JHTML::stylesheet('filename','path-to-file');will obviously not add the stylesheet but still create several "illegal string offset" notices instead of better eventually add a deprecated message to flog
(this is a recreation of a pr from @FoTo50 which went wrong