Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Shorten Explanation of "Pinned" #21879

Closed
ghost opened this issue Aug 28, 2018 · 9 comments
Closed

[4.0] Shorten Explanation of "Pinned" #21879

ghost opened this issue Aug 28, 2018 · 9 comments

Comments

@ghost
Copy link

ghost commented Aug 28, 2018

Create new banner, User get an Explanation for "Pinned":

Joomla 4

screen shot 2018-08-28 at 11 38 48

Joomla 3

User get this if hover:
screen shot 2018-08-28 at 11 38 34

Describe the solution you'd like

Short Description like "Take priority over not pinned Banners." and a Link to a Help-Site.

System information

  • Nightly Build 4.0.0-alpha5-dev
  • Multilingual Sample Data (French, German DE, Persian)
  • Template: Cassiopeia
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

  • PHP 7.1.15
  • MySQLi 5.7.18-cll-lve
@brianteeman
Copy link
Contributor

I agree 100% - the only reason I have never touched that text is because I don't understand it at all

@ggppdk
Copy link
Contributor

ggppdk commented Sep 22, 2018

Maybe this new description:
Ordering places 'binned' banners at the start of the list

@brianteeman
Copy link
Contributor

If only that was true ;)

@ggppdk
Copy link
Contributor

ggppdk commented Sep 22, 2018

hhmm the only reference i found in the source code, regarding display was in ordering these first

e.g. i do not see 'sticky' property causing an ignoring

of unpublished state
or of access level
or of publish up / down dates
etc

i only found the ordering effect
so there is more to it ?

@brianteeman
Copy link
Contributor

hint - look at the module options

@ggppdk
Copy link
Contributor

ggppdk commented Sep 23, 2018

In the banners modules

I see only the "randomize" (of ordering) option,
which i have already see the source code
in both cases the ordering places them at the top of the list

Pinned, Ordering
Pinned, Randomize

is there some other setting, that i have missed ?

@puneeth2001
Copy link
Contributor

I can work on this if I get the link to the so-called help site? Can you give me the link please..

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/21879

@Quy
Copy link
Contributor

Quy commented Feb 12, 2019

Please test PR #23836


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21879.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants