[4.0] Atum table head border bottom #21982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The border bottom was only set on `thead th` This pr correctly sets it on `thead td` as well _(cannot be tested with patchtester alone)_
|
For those that don't understand - it is not semantically correct to have a TH on a cell that is NOT a header. That cell must be a TD |
|
I have tested this item ✅ successfully on 6bfa3fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21982. |
|
I have tested this item ✅ successfully on 6bfa3fd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21982. |
|
Ready to Commit after two successful tests. |
joomla-cms-bot
added
PR-4.0-dev
and removed
RTC
|
Thanks |
|
thanks |
Closed
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jul 17, 2019
Third redo of joomla#21982 Removed again by joomla#23903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The border bottom was only set on
thead thThis pr correctly sets it onthead tdas well(cannot be tested with patchtester alone)
Before
After