Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [a11y] Move search label #21985

Merged
merged 2 commits into from
Sep 10, 2018
Merged

[4.0] [a11y] Move search label #21985

merged 2 commits into from
Sep 10, 2018

Conversation

brianteeman
Copy link
Contributor

Simple PR to move the search label (visually hidden) to being in the same div as the search input in the toolbar. This will help to improve accessibility

Simple PR to move the search label (visually hidden) to being in the same div as the search input in the toolbar. This will help to improve accessibility
@zwiastunsw
Copy link
Contributor

I have tested this item ✅ successfully on 4f74674


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21985.

@baernm
Copy link

baernm commented Sep 8, 2018

I have tested this item ✅ successfully on 4818537


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21985.

@ghost
Copy link

ghost commented Sep 8, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 8, 2018
@laoneo laoneo added this to the Joomla 4.0 milestone Sep 10, 2018
@laoneo laoneo merged commit 7797825 into joomla:4.0-dev Sep 10, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 10, 2018
@laoneo
Copy link
Member

laoneo commented Sep 10, 2018

Thanks

@brianteeman brianteeman deleted the search branch September 10, 2018 06:53
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants