Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure manifest object returned before logging actions #22237

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Make sure manifest object returned before logging actions #22237

merged 1 commit into from
Oct 2, 2018

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue #22221.

Summary of Changes

This PR added some check to make sure $installer return a manifest object before logging install/uninstall/update action. Although it doesn't fix the root of the error, it is added to make sure install/uninstall/update process still working well as expected when action logs is enabled.

Testing Instructions

  1. Install latest staging (or 3.9 beta)
  2. Follow the instructions at Uninstall library extension type throws error #22221 , install/uninstall test library to confirm the issue
  3. Apply patch, confirm the fatal error does not happen again

Documentation Changes Required

None

@ReLater
Copy link
Contributor

ReLater commented Sep 19, 2018

I have tested this item ✅ successfully on ad8d53c

Several libraries and packages with libraries successfully installed/uninstalled.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22237.

@joomdonation
Copy link
Contributor Author

Could someone help testing this simple PR? The fatal error when uninstall library should be fixed for 3.9

@Quy
Copy link
Contributor

Quy commented Sep 26, 2018

I have tested this item ✅ successfully on ad8d53c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22237.

@Quy
Copy link
Contributor

Quy commented Sep 26, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22237.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 26, 2018
@infograf768 infograf768 added this to the Joomla 3.9.0 milestone Sep 29, 2018
@mbabker mbabker merged commit 20fc0e9 into joomla:staging Oct 2, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Oct 2, 2018
@joomdonation joomdonation deleted the patch-21 branch October 2, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants