Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged Items ugly Joomla Bug #22589

Closed
ghost opened this issue Oct 12, 2018 · 22 comments
Closed

Tagged Items ugly Joomla Bug #22589

ghost opened this issue Oct 12, 2018 · 22 comments

Comments

@ghost
Copy link

ghost commented Oct 12, 2018

Steps to reproduce the issue

Menu Title > Drop number

Details
Menu Item Type > Tagged Items
Tag > Drop number
Content Type > Article

Menu > Main menu
Parent Item > SMALL
Ordering > Drop number

Expected result

/small/drop-number/brin-te

Actual result

/?view=article&id=54:brin-te&catid=12

System information (as much as possible)

Joomla 3.8.13
PHP 7.1
MySQL 5.7

Additional comments

How to fix this?

@infograf768
Copy link
Member

Have you created a menu item for the category of the article, or a List All categories menu item?
If not, test that.

@csthomas
Copy link
Contributor

Take a look at the nice list:
#22450
#22036
#21935
#20892
#20242
#19997
#19729
#19537
#19497
#18818
#18771
#17719
#17096
#16496
#14175

I prepared PR to solve that on J4 but the is no testers for #22229

I can prepare similar PR for J3 but it requires more people to be involved. Testers are needed. Last time when I did it, I made a few mistakes and PRs were reverted in J3.8.5.

@ghost
Copy link
Author

ghost commented Oct 12, 2018

Yes menu item for the category of the article Menu Item Type > Tagged Items

but Actual result still is

/?view=article&id=54:brin-te&catid=12

@infograf768 can you be more specific how to test this or is there a documentation ?

@ghost
Copy link
Author

ghost commented Oct 12, 2018

@csthomas the list of bugs is big please please prepare similar PR for J3 if it solves this joomla bug

@SharkyKZ
Copy link
Contributor

Do you have URL Routing set to Modern?

@ghost
Copy link
Author

ghost commented Oct 12, 2018

Yes URL Routing set to Modern

@csthomas
Copy link
Contributor

My PR would only replace /?view=article&id=54:brin-te&catid=12 by something like /component/content/article/54:brin-te?catid=12 or /component/content/article/12-your-category-alias/54:brin-te.

If there are more people interested, I will try to find more time to do it.

If you want to have a nicer URL, you need to set the menu item for each top category or for categories view. You should find more information in mentioned issues above.

@ghost
Copy link
Author

ghost commented Oct 12, 2018

@csthomas @infograf768 so it is imposible to make

Expected result
/small/drop-number/brin-te
Actual result
/?view=article&id=54:brin-te&catid=12

after pr the best joomla can make is /component/content/article/12-your-category-alias/54:brin-te. ? not /small/drop-number/brin-te ?

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Oct 12, 2018

You can't use one component (in this case com_tags) to automatically build an URL for another component (com_content). You can only do this manually by making the article a child menu item of Tagged Items menu item. You'd have to do this for every article tagged with your tag. To avoid that, you should use Categories, not Tags, to structure your site.

@csthomas
Copy link
Contributor

Without the appropriate menu items it is impossible. Please read mentioned issues to see what options do you have. @SharkyKZ's comment is correct.

I suggest to take a look at #22450 (comment) . As the home page, you can set the category view for "Top Category". Other categories move into "Top Category".

@ghost
Copy link
Author

ghost commented Oct 12, 2018

@SharkyKZ could you please explain what is the correct way to get this using tags?

Expected result
/small/drop-number/brin-te
Actual result
/?view=article&id=54:brin-te&catid=12

@ghost
Copy link
Author

ghost commented Oct 12, 2018

@infograf768 is there documentation on how these Tagged Items should work using modern routing?

@infograf768
Copy link
Member

This imho is not related to tagged items, it is a general issue with Modern routing.

Until @csthomas patch is tested and does work without B/C issues, the best solution [again] is to create a List All Categories menu item, even hidden, as a root menu item in your menu.
Let's say this menu item alias is listallcat

You will never get anyway
/small/drop-number/brin-te

but
/listallcat/brin-te

@ReLater ReLater mentioned this issue Oct 13, 2018
@infograf768
Copy link
Member

I mean if you do not have a direct menu item to the article.

@ghost
Copy link
Author

ghost commented Oct 17, 2018

@infograf768 After you create a menuitem for the tag you still get /component/tags/tag/tag-name when you click on article and scrool down to the tag.

What are your steps to reproduce /tags/tagname ?

@radioagent
Copy link

I have menu item with category blog. Category contain 45 articles. When i press to this menu item i see 10 articles. And all these articles have same tag. It looks like that tag filter is applied.
If i will manually go to links with ?filter_tag[0]="something" i can change set of articles in the blog without filters. It looks like filtering is applied and stored somewhere when i try to look on list of all articles.

Is it same error? Or i should create new bug report?

@csthomas
Copy link
Contributor

@radioagent Your issue is different. The filters are applied in menu item - go to backend, edit the menu item and select/deselect tags.

@ghost
Copy link

ghost commented Mar 29, 2019

@Hackwar can you please comment about the Router-Aspects?

@Hackwar
Copy link
Member

Hackwar commented Mar 29, 2019

This is expected behavior and your website is not correctly configured. Even if @infograf768 thinks it's wrong, you still have to create menu items for your content, otherwise you get crap URLs. That the tagging system is also crap, is a different story. I wouldn't know what else to say about this.

@brianteeman
Copy link
Contributor

@Hackwar please be careful with your words

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/22589

@ghost
Copy link

ghost commented Mar 29, 2019

@Hackwar thanks for Comment, closing Issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22589.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants