Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plg_system_privacyconsent] Don't redirect on menu logout #22939

Merged
merged 1 commit into from Nov 10, 2018
Merged

[plg_system_privacyconsent] Don't redirect on menu logout #22939

merged 1 commit into from Nov 10, 2018

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Nov 5, 2018

Pull Request for Issue # .

Summary of Changes

Prevents plugin from running when logging out through a menu item.

Testing Instructions

Create Users » Logout menu item.
Login to frontend with user that hasn't consented yet.
Attempt to logout through the menu item.

Expected result

Can logout.

Actual result

Can't logout, redirected to profile page.

Documentation Changes Required

No.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Nov 5, 2018

Note, this does not fix #22938.

@ReLater
Copy link
Contributor

ReLater commented Nov 6, 2018

I have tested this item ✅ successfully on 32a6625


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22939.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Nov 6, 2018

I have tested this item ✅ successfully on 32a6625


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22939.

@Quy
Copy link
Contributor

Quy commented Nov 6, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22939.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 6, 2018
@mbabker mbabker added this to the Joomla 3.9.1 milestone Nov 10, 2018
@mbabker mbabker merged commit 9d12498 into joomla:staging Nov 10, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Nov 10, 2018
@SharkyKZ SharkyKZ deleted the menulogout branch November 10, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants