-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libraries][installer] - ModuleAdapter #22984
Conversation
It fixes plugin update issue. |
Please, replace
->where($db->quoteName('client_id') . ' = ' . (int) $this->extension->client_id);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this line :
joomla-cms/libraries/src/Installer/Adapter/ModuleAdapter.php
Line 701 in 1ea6ca6
$this->extension->delete($this->extension->extension_id);
should be placed after the query (line 717), when we have finished using it.
It is better to delete the object, when we no longer need it.
@twister65 That should really be a separate pull request instead of lumped in with another unrelated change. |
See (test) PR #22993 please. |
I have tested this item ✅ successfully on 3617699 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22984. |
I have tested this item ✅ successfully on 3617699 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22984. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22984. |
Pull Request for a partial fix to Issue #22949 .
Summary of Changes
cast to int for postgresql
Testing Instructions
see #22949