Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Dont hide stats data when not needed #23033

Closed
wants to merge 1 commit into from
Closed

[4.0] Dont hide stats data when not needed #23033

wants to merge 1 commit into from

Conversation

PhilETaylor
Copy link
Contributor

Closes #22980 -

Summary of Changes

Dont hide data when we dont need to, also negates the need to choose between "click" and "select"

Expected result

screenshot 2018-11-11 at 01 50 08

Actual result

screenshot 2018-11-09 at 15 32 35

@@ -22,6 +22,7 @@ PLG_SYSTEM_STATS_MODE_OPTION_ON_DEMAND="On demand"
PLG_SYSTEM_STATS_MSG_ALLOW_SENDING_DATA="Enable Joomla Statistics?"
PLG_SYSTEM_STATS_MSG_JOOMLA_WANTS_TO_SEND_DATA="To better understand our install base and end user environments it is helpful if you send some site information back to a Joomla! controlled central server. No identifying data is captured at any point. You can change these settings later from Plugins > System - Joomla! Statistics."
PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT="Select here to see the information that will be sent."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete obsolete string?

This comment was marked as abuse.

@Quy
Copy link
Contributor

Quy commented Nov 11, 2018

Update \media\plg_system_stats\js\stats.js to remove the toggler code?

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

not a fan of displaying this by default. what is the benefit

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

There is plenty of.reasons to hide it. It is overly technical for the ordinary user. They really only need.to set the plugin options. Anything else is scary and should be optionally displayed only to those that need to see it.

As for click. @mbabker already stated the reason and this change was made a few years ago. I guess you didn't notice.

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor

mbabker commented Nov 11, 2018

if the version numbers of your stack are "too technical" then you should not be running Joomla.

Contrary to your opinion, software like Joomla and WordPress are not exclusive applications that can only be utilized by computer science majors or other trained and/or certified individuals. You should not bombard someone with technical data they may not understand and tell them "understand it or do not use the software", that's bad UX unless your software is ONLY targeting developers (and even then it's bad unless your target is ONLY developers who are already in the know about whatever the subject is).

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor PhilETaylor deleted the SelectHere branch November 11, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants