-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the URL to the PHP Date Function #23082
Conversation
Current: http://www.php.net/manual/en/function.date.php - this URL does not work it requires signing into the php.net site Proposed: http://php.net/date - this URL works and is consistent with other language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on 6cbe0bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23082. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23082. |
This is clearly an upstream problem with the mirror that you are being directed to. Have you reported it upstream so it can be fixed for everyone that uses php |
Yes, the problem has been reported - Bug #77161 - PHP.net Website Problem (https://bugs.php.net/bug.php?id=77161). |
This comment was marked as abuse.
This comment was marked as abuse.
Good Idea. I thought that the IP address would be stored along with the bug report when you create one, just like we can find out from which IP address the post has been created in the Joomla! Forum. |
Co-Authored-By: imanickam <mig.joomla@gmail.com>
Original URL - http://php.net/date Revised URL - https://php.net/date
Standardized the URL that references the date function in PHP from http://php.net/date to https://php.net/date. This has been changed in the file en-GB.mod_articles_category.ini (that is located in the directory \language\en-GB) as well. The URLs are changed in the language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC |
Current:
http://www.php.net/manual/en/function.date.php - this URL does not work; it requires signing into the php.net site
Proposed:
http://php.net/date - this URL works and is consistent with other language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC
Pull Request for Issue # .
Summary of Changes
Current language string:
JGLOBAL_DATE_FORMAT_DESC="Optional format string for showing the date. For example, D M Y for day month year or you can use d-m-y for a short version eg. 28-12-16. See http://www.php.net/manual/en/function.date.php. If left blank, it uses DATE_FORMAT_LC1 from your language file."
Revised language string:
JGLOBAL_DATE_FORMAT_DESC="Optional format string for showing the date. For example, D M Y for day month year or you can use d-m-y for a short version eg. 28-12-16. See http://php.net/date. If left blank, it uses DATE_FORMAT_LC1 from your language file."
Testing Instructions
(a) Go to the screen "Articles: Options" (Content => Articles > Options)
(b) Click on the tab List Layouts
(c) For the option "Show Date", choose the value Created or Modified or Published)
(d) Move the cursor over the label "Date Format" - Review the pop-up help text
(e) Type the URL shown in the pop-up help text in a separate window/tab of a browser and see what happens
Expected result
(a) Pop-up Help Text
(b) URL to the PHP Date Function taken from the pop-up Help Text
Actual result
(a) Pop-up Help Text
(b) URL to the PHP Date Function taken from the pop-up Help Text
Documentation Changes Required