Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the URL to the PHP Date Function #23082

Merged
merged 3 commits into from
Nov 17, 2018
Merged

Change the URL to the PHP Date Function #23082

merged 3 commits into from
Nov 17, 2018

Conversation

imanickam
Copy link
Contributor

Current:
http://www.php.net/manual/en/function.date.php - this URL does not work; it requires signing into the php.net site

Proposed:
http://php.net/date - this URL works and is consistent with other language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC

Pull Request for Issue # .

Summary of Changes

Current language string:
JGLOBAL_DATE_FORMAT_DESC="Optional format string for showing the date. For example, D M Y for day month year or you can use d-m-y for a short version eg. 28-12-16. See http://www.php.net/manual/en/function.date.php. If left blank, it uses DATE_FORMAT_LC1 from your language file."

Revised language string:
JGLOBAL_DATE_FORMAT_DESC="Optional format string for showing the date. For example, D M Y for day month year or you can use d-m-y for a short version eg. 28-12-16. See http://php.net/date. If left blank, it uses DATE_FORMAT_LC1 from your language file."

Testing Instructions

(a) Go to the screen "Articles: Options" (Content => Articles > Options)
(b) Click on the tab List Layouts
(c) For the option "Show Date", choose the value Created or Modified or Published)
(d) Move the cursor over the label "Date Format" - Review the pop-up help text
(e) Type the URL shown in the pop-up help text in a separate window/tab of a browser and see what happens

Expected result

(a) Pop-up Help Text

after_language_string_change

(b) URL to the PHP Date Function taken from the pop-up Help Text

php_function-date_url_without_www

Actual result

(a) Pop-up Help Text

before_language_string_change

(b) URL to the PHP Date Function taken from the pop-up Help Text

php_function-date_url_with_www

Documentation Changes Required

Current:
http://www.php.net/manual/en/function.date.php - this URL does not work it requires signing into the php.net site

Proposed:
http://php.net/date - this URL works and is consistent with other language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC
@PhilETaylor

This comment was marked as abuse.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 6cbe0bc

If this may help some users, let's change it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23082.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@infograf768 infograf768 removed Language Change This is for Translators PR-staging labels Nov 15, 2018
@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23082.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 15, 2018
@brianteeman
Copy link
Contributor

This is clearly an upstream problem with the mirror that you are being directed to. Have you reported it upstream so it can be fixed for everyone that uses php

@imanickam
Copy link
Contributor Author

This is clearly an upstream problem with the mirror that you are being directed to. Have you reported it upstream so it can be fixed for everyone that uses php

Yes, the problem has been reported - Bug #77161 - PHP.net Website Problem (https://bugs.php.net/bug.php?id=77161).

@PhilETaylor

This comment was marked as abuse.

@imanickam
Copy link
Contributor Author

Might be worth telling the PHP guys where you are in the world, and maybe your IP because then they might be able to "guess" which mirror you get redirected to.

Good Idea. I thought that the IP address would be stored along with the bug report when you create one, just like we can find out from which IP address the post has been created in the Joomla! Forum.

Co-Authored-By: imanickam <mig.joomla@gmail.com>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Nov 15, 2018
@imanickam
Copy link
Contributor Author

Standardized the URL that references the date function in PHP from http://php.net/date to https://php.net/date.

This has been changed in the file en-GB.mod_articles_category.ini (that is located in the directory \language\en-GB) as well.

The URLs are changed in the language strings MOD_ARTICLES_CATEGORY_FIELD_DATEFIELDFORMAT_DESC and MOD_ARTICLES_CATEGORY_FIELD_MONTHYEARFORMAT_DESC

@mbabker mbabker added this to the Joomla 3.9.1 milestone Nov 17, 2018
@mbabker mbabker merged commit a43029d into joomla:staging Nov 17, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 17, 2018
@imanickam imanickam deleted the patch-9 branch November 19, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants