basic support for tags in com_banners #23207
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds basic support for tagging banners. The banner form will have a tags field which should work exactly like the tags field for other content-types.
It may be necessary to add a few more tag-related features to this (searching, etc.) before merging it but I'm putting in the PR now to hopefully get some feedback. I don't see any harm in adding tags to banners and there can surely be some benefits to it. However, since banners has been without tag support until now, I wonder if there could have been some reason other than simple oversight or disinterest. So I want to know, is this or is this not doable? Are there any potential problems to be aware of?
If it looks like there's no issue, I'll go ahead and complete this PR.
Testing Instructions
Create or edit a banner. Add or remove tags. Save it.
Expected result
Tags should be saved along with your banner.
Actual result
Works for me.
Documentation Changes Required
Maybe?