Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic support for tags in com_banners #23207

Closed

Conversation

okonomiyaki3000
Copy link
Contributor

Summary of Changes

Adds basic support for tagging banners. The banner form will have a tags field which should work exactly like the tags field for other content-types.

It may be necessary to add a few more tag-related features to this (searching, etc.) before merging it but I'm putting in the PR now to hopefully get some feedback. I don't see any harm in adding tags to banners and there can surely be some benefits to it. However, since banners has been without tag support until now, I wonder if there could have been some reason other than simple oversight or disinterest. So I want to know, is this or is this not doable? Are there any potential problems to be aware of?

If it looks like there's no issue, I'll go ahead and complete this PR.

Testing Instructions

Create or edit a banner. Add or remove tags. Save it.

Expected result

Tags should be saved along with your banner.

Actual result

Works for me.

Documentation Changes Required

Maybe?

@SharkyKZ
Copy link
Contributor

This will need special handling in com_tags and mod_tags_similar because banner doesn't have frontend view. So we can't link to it.

@mbabker
Copy link
Contributor

mbabker commented Nov 30, 2018

This will need special handling in com_tags and mod_tags_similar because banner doesn't have frontend view. So we can't link to it.

And I'm fairly sure that's why tags support was never added to com_banners in the first place. This isn't saying having it isn't possible, but it does mean we need to think about the integration for a content type that doesn't actually have its own frontend.

@okonomiyaki3000
Copy link
Contributor Author

I'll think about how we might handle that. Because I do think there are some good reasons to want to tag banners.

@Bakual
Copy link
Contributor

Bakual commented Dec 3, 2018

Because I do think there are some good reasons to want to tag banners.

Maybe start with writing some of them. Because honestly I don't see any right now (doesn't mean there aren't).
If we know what you want to achieve, then the implementation can follow.

@ghost ghost added J3 Issue and removed J3 Issue labels Apr 5, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@ghost
Copy link

ghost commented Jul 20, 2019

closed due the lack of response.

@ghost ghost closed this Jul 20, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants