Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] fix a todo, drop the slider button #23388

Merged
merged 9 commits into from
Feb 5, 2019
Merged

[4.0] fix a todo, drop the slider button #23388

merged 9 commits into from
Feb 5, 2019

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • This button is not used anywhere in the core
  • This button was based on mootools and mootools are not here anymore
  • This PR drops that button!!!
  • Javascript code was wrongly appended in shown.js
  • That code is now deleted
  • Classmap updated

Testing Instructions

Slider was not used anywhere in the core anyways so code review is what is needed here

Expected result

Actual result

Documentation Changes Required

This is a B/C break and needs to be documented and also communicated!!!!

…ix-todo

* '4.0-dev' of github.com:joomla/joomla-cms:
  Fixing com_fields integration in com_contact (#20413)
  [com_contenthistory] - fix for not delete keep forever items (#20430)
  [com_tags] Images in Tagged Items view (#20601)
  Additional Escaping Of Paths In com_media (#20616)
  Respect access of editor plugin inside profile form (#20713)
  Better mode autoloading. (#20746)
  Mouse over edit - rename (#20743)
  Login to view the article redirect fix (#20732)
  Add UTF-8 encoding to phpcs in .drone.yml (#20769)
  Com_finder meta data (#20772)
  [mod_tags_similar] Link cleanup (#20730)
  [com_tags] Tagged item link in feed (#20723)
  Put all build packages in one directory (#20745)
@Quy
Copy link
Contributor

Quy commented Dec 29, 2018

Add deleted files to the list in administrator/components/com_admin/script.php?

@Hackwar
Copy link
Member

Hackwar commented Dec 30, 2018

May I ask what this button did? Would we need something like this again? Somehow I had an input element of type "range" in my mind when reading this, but as a button? Anyway, good that you are removing this stuff. 😉 I don't think that you have to add any files to the deleted files list, since that most likely has to happen by script shortly before we go to RC.

@Hackwar
Copy link
Member

Hackwar commented Dec 30, 2018

I have tested this item ✅ successfully on cc38f14

Tested by codereview


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388.

@dgrammatiko
Copy link
Contributor Author

@Hackwar by translating the js part <div class="collapse fade" id="collapse-${name}"><iframe class="iframe" src="${url}" height="${height}" width="100%"></iframe></div> I think this was acting like an accordion kinda thingy. So when someone was clicking on that button then the container would expand and the iframe would be rendered inside.

@Quy
Copy link
Contributor

Quy commented Dec 30, 2018

It is my understanding that the list is for when upgrading to handle deleted files.

@mbabker
Copy link
Contributor

mbabker commented Dec 30, 2018

Someone can run https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php and build a full list of files at an appropriate time. Since the entire upgrade process is messed up right now, no point in randomly adding files to that list in random PRs; enforce it after everything is caught up.

@bonzani
Copy link

bonzani commented Jan 5, 2019

I have tested this item ✅ successfully on cc38f14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388.

@Quy
Copy link
Contributor

Quy commented Jan 5, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 5, 2019
@wilsonge wilsonge merged commit 9238a69 into joomla:4.0-dev Feb 5, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Feb 5, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 5, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants