-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] fix a todo, drop the slider button #23388
Conversation
…ix-todo * '4.0-dev' of github.com:joomla/joomla-cms: Fixing com_fields integration in com_contact (#20413) [com_contenthistory] - fix for not delete keep forever items (#20430) [com_tags] Images in Tagged Items view (#20601) Additional Escaping Of Paths In com_media (#20616) Respect access of editor plugin inside profile form (#20713) Better mode autoloading. (#20746) Mouse over edit - rename (#20743) Login to view the article redirect fix (#20732) Add UTF-8 encoding to phpcs in .drone.yml (#20769) Com_finder meta data (#20772) [mod_tags_similar] Link cleanup (#20730) [com_tags] Tagged item link in feed (#20723) Put all build packages in one directory (#20745)
Add deleted files to the list in |
May I ask what this button did? Would we need something like this again? Somehow I had an input element of type "range" in my mind when reading this, but as a button? Anyway, good that you are removing this stuff. 😉 I don't think that you have to add any files to the deleted files list, since that most likely has to happen by script shortly before we go to RC. |
I have tested this item ✅ successfully on cc38f14 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388. |
@Hackwar by translating the js part |
It is my understanding that the list is for when upgrading to handle deleted files. |
Someone can run https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php and build a full list of files at an appropriate time. Since the entire upgrade process is messed up right now, no point in randomly adding files to that list in random PRs; enforce it after everything is caught up. |
I have tested this item ✅ successfully on cc38f14 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388. |
Thanks! |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Slider was not used anywhere in the core anyways so code review is what is needed here
Expected result
Actual result
Documentation Changes Required
This is a B/C break and needs to be documented and also communicated!!!!