Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The publisher's options for the video should be improved. #23581

Closed
ZerooCool opened this issue Jan 17, 2019 · 9 comments
Closed

The publisher's options for the video should be improved. #23581

ZerooCool opened this issue Jan 17, 2019 · 9 comments

Comments

@ZerooCool
Copy link

Is it normal that, by default, the text editor and its add video button do not work?

If I put the link of a youtube video, from the add video button, in the default editor, the wizard will propose 3 tabs. The first tab is used to put the link of the target, the second tab offers a copy code to paste into the HTML.

Still, the HTML will be cleaned, by default, which will prevent the addition of the video.

@infograf768
Copy link
Member

I guess this is when you use TinyMCe.
Could you post here the exact code you are using and what you get after saving the item (article?) (Link can be a fake one. It does not matter.)

@ZerooCool
Copy link
Author

You can see this video : http://visionduweb.eu/video.mp4.zip

@infograf768
Copy link
Member

  1. The file is corrupted and can't be read on Macintosh
  2. I just need the lines of code used and have no time anyway to read a video and try to pick up what code was used.

@ZerooCool
Copy link
Author

I do not know for lines of code, this is the insert video icon, in the default text editor.

I guess iframes are removed by default.

Therefore, by default, the insert video icon does not work.

Even if adding a component or a plugin can correct this, I think an improvement is to be made, for the default behavior.

@infograf768
Copy link
Member

It is very easy to see in the textarea what you have done when inserting the video by just Toggling editor.
Also, TinyMCE parameters can be modified when editing the plugin:
screen shot 2019-01-18 at 17 45 59
screen shot 2019-01-18 at 17 45 53

If iframe is the culprit, then just allow it for superusers

@ZerooCool
Copy link
Author

This HTML code of the icon?

Ok yes the plugin can manage but, my point is to improve the use of Joomla, by default.

Off, if we propose a video icon in Joomla, the icon must be functional, without requiring settings in the plugins.

That's why you have to pre-set this, if possible, for the user, allowing iframes directly.

Otherwise, delete this video element.

I do not know if it's feasible simply, and easy to maintain, but it would be better for the end user.

@Bakual
Copy link
Contributor

Bakual commented Jan 22, 2019

Please use the forum (forum.joomla.org) for support requests. This is the issue tracker for bus in core code. Thanks.

@Bakual Bakual closed this as completed Jan 22, 2019
@ZerooCool
Copy link
Author

I voluntarily posted here, because, I think that just to propose an icon in the core Joomla, via its editor, which does not work by default, is not a relevant choice.

@Bakual
Copy link
Contributor

Bakual commented Jan 23, 2019

Just because it by default doesn't work with Youtube (because they use iframes) doesn't mean the media button is broken by default. It works for all kind of inserts that don't use iframes.
Allowing iframes by default would be a very bad idea.
So if you want to allow that for your authors/users, it has to be an informed choice of you as administrator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants