New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove plg_fields_repeatable #23659
Comments
@infograf768 can you please comment? |
@infograf768 reminder |
@infograf768 thanks for Comment. So its for @HLeithner or @wilsonge |
We can't remove anything in a minor version. At least not following the semver definition. |
I think repetable field is already use in many extension ... Try to start migration now Can be interesting now for less work on j4 migration |
Migration seams not to be the problem (script is ready) but layout overrides may have to be changed. |
It would make sense in this case to merge #22446 so people have a version where they can migrate their fields out of repeatable and into the subform field. But yes the repeatable field cannot be removed until 4.0 - but we can of course mark it as deprecated as soon as that is merged |
AMENDMENT TO ABOVE: Apologies. I missed there was a migration script. If there's a migration script then the correct place to do that migration is in 4.0 and not have this in 3.10! Sorry! |
changed Title cause of above Comment by @wilsonge |
Adding release blocker label as this needs to be solved for 4.0 stable |
Increasing priority as per guidelines for beta-blockers. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23659. |
See PR #28319 Draft. |
As discussed in #22446 we need to remove the plg_fields_repeatable plugin as soon as #22446 is merged into 3.10-dev
Background: Pull request #22446 implements a new custom field type plg_fields_subfields which is capable of using predefined custom fields for use as sub fields of a subform containing those. This functionality is basically an expansion of the functionality of the plg_fields_repeatable type. Hence, to keep the Joomla! core clean, we need to remove the plg_fields_repeatable plugin.
What needs to be done is that the plg_fields_repeatable plugin needs to be removed for all new installations of Joomla!, and for all existing installations that do not use that plugin (so have no repeatable custom fields). For installations that use it, we need to either provide a transitioning-script, or we need to explain the user how to switch from the repeatable type to the subfields type. To accomplish this, we maybe first need to declare the plg_fields_subfields type as deprecated in a first step.
A first idea of how to remove the repeatable type from core and how to build a transitioning script can be found in this diff continga@71f831d
That diff was previously part of the beforementioned PR, but we decided to do the plg_fields_repeatable stuff in a separate issue and keep it outside of the scope of the plg_fields_subfields PR. That is the reason this issue got created.
So in a first place, we need to decide on the actions that need to be taken in regards to the plg_fields_repeatable plugin when #22446 got merged, and when we have decided and when #22446 is merged, we need to create an additional PR for this.
The text was updated successfully, but these errors were encountered: