Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Improve a Language String #23855

Merged
merged 5 commits into from
Feb 18, 2019
Merged

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Feb 10, 2019

Improve Language string as suggested in #23775

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Feb 10, 2019
@astridx astridx changed the title language improvment [4.0] Improve a Language String Feb 10, 2019
@brianteeman
Copy link
Contributor

As this is a new string I would change the KEY as well as the Value

@astridx
Copy link
Contributor Author

astridx commented Feb 10, 2019

@brianteeman Done. Thank you, you are right.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on d9d341f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23855.

@@ -179,7 +179,7 @@ COM_TEMPLATES_NEW_FILE_TYPE="File Type"
COM_TEMPLATES_NO_TEMPLATE_SELECTED="No template selected."
COM_TEMPLATES_OPTION_NONE=":: None ::"
COM_TEMPLATES_OPTION_SELECT_MENU_ITEM="- Select Menu Item -"
COM_TEMPLATES_OVERRIDE_ACTION="Update Action"
COM_TEMPLATES_OVERRIDE_SOURCE="Update Source"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort key in alpha order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quy Done. Thanks

@Quy
Copy link
Contributor

Quy commented Feb 15, 2019

I have tested this item ✅ successfully on d2dad1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23855.

@Quy
Copy link
Contributor

Quy commented Feb 15, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23855.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 15, 2019
@wilsonge wilsonge merged commit 6b4b570 into joomla:4.0-dev Feb 18, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 18, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Feb 18, 2019
@astridx astridx deleted the languageimprovment branch August 9, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants