Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][a11y] Insufficient label contrast ratio at all switches #23863

Closed
zwiastunsw opened this issue Feb 10, 2019 · 8 comments
Closed

[4.0][a11y] Insufficient label contrast ratio at all switches #23863

zwiastunsw opened this issue Feb 10, 2019 · 8 comments

Comments

@zwiastunsw
Copy link
Contributor

zwiastunsw commented Feb 10, 2019

Steps to reproduce the issue

  1. Go to Backend, for example on the Global Configuration page or on the Modules > Site Modules > Article Category
  2. Check the color contrast of the switch labels
    image

Expected result

Minimum required contrast ratio >= 4,5

Actual result

The labels of the options set by the switches have too low contrast to the background:
On the Global Configuration page the color combination #868e96/#ebeff5 has a contrast ratio of 2,88. Consider using the following foreground/background combination: #636e79/#ebeff5 / has a ratio of 4.51
On the Modules: Article Category page the color combination #868e96/#fefefe has a contrast ratio of 3.29, which is not sufficient. Consider using the following foreground/background combination: #6d7781/#fefefe / has a ratio of 4.52

@brianteeman
Copy link
Contributor

Shouldnt this be posted in the private template repo?

@zwiastunsw
Copy link
Contributor Author

Sorry, but.... where is the private template repository?

@brianteeman
Copy link
Contributor

I have no idea. Obviously I was mistaken in assuming that when they said they had accessibility experts that it included the JAT

@puneeth2001
Copy link
Contributor

can I work on this issue

@Quy
Copy link
Contributor

Quy commented Feb 16, 2019

@puneeth2001 You do not need to ask for permission. Go for it.

@puneeth2001
Copy link
Contributor

@Quy is it ok:
screenshot from 2019-02-17 15-39-46

@zwiastunsw
Copy link
Contributor Author

@puneeth2001 : Don't ask if it's okay. Do PR. Testers will evaluate.

@wilsonge
Copy link
Contributor

This should have been fixed by 609b77d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants