Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][Fix] Language change for toggle editor button #23892

Merged
merged 7 commits into from
Mar 15, 2019

Conversation

hardik-codes
Copy link
Contributor

Pull Request for Issue #23891

Summary of Changes

Changed the language of toggle editor button from Toggle editor to Toggle Editor

Testing Instructions

Open any article from the article list view.
If there are no articles create one.

Expected result

toggle3

Actual result

toggle 2

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Feb 13, 2019
@hardik-codes
Copy link
Contributor Author

Members please review this PR

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 8074f53

Simple test. Can be merged on review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23892.

@HLeithner
Copy link
Member

Is there a reason changing this to uppercase? I'm not a native speaker so I wonder.

@hardik-codes
Copy link
Contributor Author

Is there a reason changing this to uppercase? I'm not a native speaker so I wonder.

Other tabs such as Configure Edit Screen, which comprises of more than one word has its first letter of each word capital, the PR is just to maintain consistency

@brianteeman
Copy link
Contributor

@HLeithner
Copy link
Member

@brianteeman perfect thx, I restarted drone without (can't be merged without it)

@Quy
Copy link
Contributor

Quy commented Feb 27, 2019

I have tested this item ✅ successfully on 8074f53


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23892.

@Quy
Copy link
Contributor

Quy commented Feb 27, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23892.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2019
@wilsonge wilsonge merged commit 73f34b9 into joomla:4.0-dev Mar 15, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 15, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 15, 2019
@hardik-codes hardik-codes deleted the ToggleEditor branch April 18, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants