-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Add support to unpublish module from Control Panel #23934
Conversation
@brianteeman All done. Thanks |
I have tested this item ✅ successfully on d88d161 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934. |
Drone throws errors for javascript-cs |
Thats a great improvement, I'd open a seperate issue with following problem: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934. |
Thanks Elisa. I'll add the refer link. |
@coolcat-creations are you sure you ran npm i after applying the patch. If you didnt then the dropdown appears but the functionality behind it is not present |
Unpublish works fine here. |
If that feature is the correct approach then sure |
Regarding the "return" This issue is common in very many places. eg adding a note to a user |
I do think indeed it makes sense to redirect to CPanel when editing the module from there. |
I'll leave it up to your guys then. RTC if you want or I can add the redirect in. |
+1 for redirecting to CPanel. |
On second thoughts, adding a redirect is out of scope of this PR. This is purely to add support for unpublishing a module via the front-end and does not touch how the edit functionality works. @coolcat-creations @infograf768 Please create a separate issue |
@wilsonge conflicts resolved |
@wilsonge conflicts resolved again |
Restarted drone... |
I have tested this item ✅ successfully on 952d583 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934. |
@brianteeman can you please retest? |
administrator/templates/atum/scss/vendor/bootstrap/_dropdown.scss
Outdated
Show resolved
Hide resolved
Co-Authored-By: C-Lodder <lodder15@hotmail.co.uk>
I have tested this item ✅ successfully on a1b150b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934. |
@coolcat-creations |
I have tested this item ✅ successfully on 52fb2cb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934. |
Thankyou! |
Please test #24109 for the redirection. |
Summary of Changes
This is a continuation of the initial prototype I did: joomla/40-backend-template#251
In the control panel, we have a cog icon that directs you to the settings for that module. Now, it displays a dropdown with a new option to directly unpublish the module. Upon doing so, it will instantly disappear from the display.
Testing Instructions
npm i
(apologies)Note
There are some changes to other files which keeps the dropdowns in other areas of the admin template intact.