Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][a11y]Replace link by button in com_contact #24186

Closed
wants to merge 1 commit into from

Conversation

hardik-codes
Copy link
Contributor

This PR replaces link by a button for the dismiss button in com_contact

Summary of Changes

Replaced < a Tag by the correct < button Tag

Testing Instructions

Code inspection

@brianteeman
Copy link
Contributor

this and most other cases like this have already been fixed in joomla 3 and are just waiting for @wilsonge to merge them upstream into j4

there are plenty of things to do without re-doing code that is already solved.

@hardik-codes
Copy link
Contributor Author

hardik-codes commented Mar 13, 2019

this and most other cases like this have already been fixed in joomla 3 and are just waiting for @wilsonge to merge them upstream into j4

Ok, I didn't know about that.

@hardik-codes
Copy link
Contributor Author

there are plenty of things to do without re-doing code that is already solved

Could you please let me know some of them so that I can start working on them.

@hardik-codes hardik-codes changed the title [4.0]Replace link by button in com_contact [4.0][a11y]Replace link by button in com_contact Mar 13, 2019
@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24186

@Quy
Copy link
Contributor

Quy commented Mar 14, 2019

Closing as stated per brianteeman.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24186.

@hardik-codes hardik-codes deleted the linkToButton branch April 19, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants