Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Namespace classes #24225

Merged
merged 4 commits into from
Mar 19, 2019
Merged

[4.0] Namespace classes #24225

merged 4 commits into from
Mar 19, 2019

Conversation

hardik-codes
Copy link
Contributor

@hardik-codes hardik-codes commented Mar 17, 2019

Summary of Changes

Used namespace classes in

  • installation/template/message.php

Testing Instructions

Code Inspection

@Quy
Copy link
Contributor

Quy commented Mar 18, 2019

I have tested this item ✅ successfully on 7aad637


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24225.

@mbabker
Copy link
Contributor

mbabker commented Mar 18, 2019

Remove non-install changes or close per #24188

@hardik-codes
Copy link
Contributor Author

Remove non-install changes or close per #24188

@mbabker Could you please elaborate which 'non-install changes' you are referring to ? I'll fix them asap.

@SharkyKZ
Copy link
Contributor

Those in com_privacy and com_userlogs. They should be left alone for now as per request in #24188.

@hardik-codes
Copy link
Contributor Author

@SharkyKZ @mbabker now have a look.

@chmst
Copy link
Contributor

chmst commented Mar 19, 2019

I have tested this item ✅ successfully on 73bde52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24225.

@ghost
Copy link

ghost commented Mar 19, 2019

@Quy please retest.

@wilsonge wilsonge merged commit ba44e5f into joomla:4.0-dev Mar 19, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 19, 2019
@wilsonge
Copy link
Contributor

Thanks!

@hardik-codes hardik-codes deleted the useNamespace branch April 18, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants