Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] mod_languages php notice on error page #24270

Closed
wants to merge 3 commits into from

Conversation

brianteeman
Copy link
Contributor

If you have the language switcher module published and you go to a 404 error page then you will see this
image

Apply the patch and the php warning is gone

If you have the language switcher module published and you go to a 404 error page then you will see this

Apply the patch and the php notice is gone
Co-Authored-By: brianteeman <brian@teeman.net>
@SharkyKZ
Copy link
Contributor

Instead of defining the (un)constant, just replace it with the value. It's deprecated anyways, see #21678.

@brianteeman
Copy link
Contributor Author

lol - it was me that did the deprecation

I will update the pr soon

@infograf768
Copy link
Member

Folks, this has already been corrected in 3.9.x. It is just a matter to wait for @wilsonge to merge.
See #22403

@brianteeman
Copy link
Contributor Author

ok thanks - closed

@brianteeman brianteeman deleted the error branch March 21, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants