[4.0] Added password strength checker and viewer #24404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides the header and options in full screen mode to prevent overlap over the editor area in full-screen mode. Another possible alternative is displaying both the options as well as the editor in full-screen mode but purely a user preference. Because the need for save and other options is not as important in full-screen mode.
|
we already have a password strength checker |
I just thought a visual feedback while typing the password would be a good choice, as most nowadays have it. Will try to integrate the visual feedback with the existing strength checker |
|
yes it is a good idea. that is why it already exists!!
|
|
Sorry, didn't notice this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Added javascript that checks for password strength and displays it to the user.
Pretty basic checking with special characters, lowercase and uppercase letters and numbers.
Could use a better checking process like that of dropbox's zxcvbn project.
Testing Instructions
Visit home page
Create an account
Type in some password
Expected result