Multi category - blog layout view #24412
Conversation
This allow to choose on the menu if articles that are not feature are displayed in this view
This allow to choose on the menu if articles that are not feature are displayed in this view.
|
One should at least also adjust the various language strings to indicate that the featured view now is not really a featured view anymore but a mutlicategory view (with optional featured filter). |
| @@ -67,8 +67,10 @@ protected function populateState($ordering = null, $direction = null) | |||
| $limit = $params->get('num_leading_articles') + $params->get('num_intro_articles') + $params->get('num_links'); | |||
| $this->setState('list.limit', $limit); | |||
| $this->setState('list.links', $params->get('num_links')); | |||
|
|
|||
| if($featuredCategories = $params->get('show_only_featured',1)) | |||
| @@ -67,8 +67,10 @@ protected function populateState($ordering = null, $direction = null) | |||
| $limit = $params->get('num_leading_articles') + $params->get('num_intro_articles') + $params->get('num_links'); | |||
| $this->setState('list.limit', $limit); | |||
| $this->setState('list.links', $params->get('num_links')); | |||
|
|
|||
| if($featuredCategories = $params->get('show_only_featured',1)) | |||
| { | |||
| $this->setState('filter.frontpage', true); | |||
| type="list" | ||
| label="COM_CONTENT_FEATURED_ARTICLES" | ||
| description="COM_CONTENT_FEATURED_CATEGORIES_DESC" | ||
| useglobal="true" |
There was a problem hiding this comment.
if useglobal is true, it means that the field should be added in the component options...
There was a problem hiding this comment.
Yes maybe there, can you confirm that the file is located at administrator/components/com_content/config.xml after line 826.
There was a problem hiding this comment.
Do you think that the new parameter should be in this global blog configuration screen?
There was a problem hiding this comment.
I'd rather not use "useglobal" here. Because it's a rather view specific parameter which can only ever be used together with a menuitem.
There was a problem hiding this comment.
Ok I will remove the Use global and submit again. Thanks @Bakual .
Adding a space and tab
|
please rebase this on j4.0 |
Please explain what do you mean with rebase? |
Remove the useglobal from show_only_featured.
|
this is a new feature and we have a feature freeze for j 3.9 so all new features go to 4.0. |
So a make a PR to joomla:staging will it be accepted? Can it be accepted in staging and go to 4.0 next? Do I have to make a PR to joomla:4.0-dev? |
That. |
Add space after if
Set default to 1 on show_only_featured
|
can we close this one as we have #24454 |
ghost
closed this
Pull Request for Issue #24383 .
Summary of Changes
Changing this 2 files makes possible to display articles from choose categories in the same view, page.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
Now feature menu allows to display items that are not featured. A mutlicategory view (with optional featured filter)