Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Update checks - no indication #24443

Open
brianteeman opened this issue Apr 1, 2019 · 2 comments
Open

Failing Update checks - no indication #24443

brianteeman opened this issue Apr 1, 2019 · 2 comments

Comments

@brianteeman
Copy link
Contributor

brianteeman commented Apr 1, 2019

Steps to reproduce the issue

Easiest way is to have a local site and disconnect from the internet. Confirm that your site cannot see updated by checking for updates using the joomla update component

Expected result

In J3 the checks for new joomla and extensions will display an error on the control panel bottom left
In J4 the checks for new joomla and extensions will display an error on the control panel icons
In J4 the ajax checks for new joomla and extensions will display an error on the system dashboard

Actual result

No errors and everything reported as upto date. I noticed this on a client site where the sysadmin had firewalled the server to prevent external checks. As a result they didnt know they were multiple versions out of date

Additional comments

Some sort of icon/text (depending on the location) to show a warning that the site couldnt check would be the minimum expected.
Definitely is wrong to show as upto date

This really should be fixed in J3 and J4 but will probably need separate PR as the code is different for this

@brianteeman brianteeman changed the title Update checks Failing Update checks - no indication Apr 1, 2019
@zero-24 zero-24 assigned zero-24 and unassigned zero-24 Apr 1, 2019
@ghost ghost added the J3 Issue label Apr 4, 2019
@brianteeman
Copy link
Contributor Author

please add the j4 tag as well as the j3 tag a it is relevant to both

@ghost ghost added the J4 Issue label Apr 8, 2019
@infograf768
Copy link
Member

The messages exist, but are displayed only when loading the update page administrator/index.php?option=com_installer&view=update

They are fetched (for each update site) from the getUpdateSiteResponse method in root/libraries/src/Updater/UpdateAdapter.php when $response is null.

@rdeutz rdeutz removed the J3 Issue label Aug 24, 2022
@Hackwar Hackwar added the bug label Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants