[4.0] Fix filter for workflows #24864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update to the right issue for this PR. |
|
done, sry |
|
I have tested this item ✅ successfully on eafbd9c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864. |
|
I dont see how this has anything to do with #24814 |
|
Could you test please? I think setting the filter right does the trick also for you. |
|
I did test |
chmst
changed the title
|
Description changed. |
|
I have tested this item ✅ successfully on 3e45bc5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864. |
|
@Quy can you please retest? |
|
I have tested this item ✅ successfully on 3e45bc5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864. |
|
Thank you. As stated this solves a different issue than #24814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24814
Summary of Changes
The #__workflows table uses column name published. This causes several issues. One of them is that the ordering of workflows via state is not possible.
Another isssue is that filters are not set, as described in the related issue.
Testing Instructions
Ordering:
You must have at least two workflows. Set one of the unpublished and try ordering of the column "state"
Active Filters:
Or see test instruction in the related issue.
Expected result
Columns are ordered new if possible
Active Filters are set
Actual result
No ordering possible, active Filters are not set.
Documentation Changes Required
no, it is a bug