Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onContentValidateData event. #24925

Closed
wants to merge 9 commits into from
Closed

Added onContentValidateData event. #24925

wants to merge 9 commits into from

Conversation

BrainforgeUK
Copy link
Contributor

Pull Request for Issue #19584.

Summary of Changes

Added event onContentValidateData

Testing Instructions

Create a field plugin which implements onContentValidateData function like this...
public function onContentValidateData($form, &$data) {
// Change the data in some way
}

Expected result

The data get's changed.

Actual result

The data get's changed.

Documentation Changes Required

Add documentation for onContentValidateData event.
Add documentation for the existing, but undocumented and now deprecated, onUserBeforeDataValidation event.

Replaces `onUserBeforeDataValidation` event which is now deprecated.
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label May 16, 2019
@BrainforgeUK
Copy link
Contributor Author

BrainforgeUK commented May 16, 2019

Also added com_install change commit for 'Improved extension update error message' by accident. This applies to Joomla issue #22762.
I am struggling with how to create 2 pull requests for separate issues.

Undone the mentioned com_install change.

@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label May 16, 2019
@SharkyKZ
Copy link
Contributor

I am struggling with how to create 2 pull requests for separate issues.

Instead of making changes to 4.0-dev branch, create separate branches for each PR.

@BrainforgeUK
Copy link
Contributor Author

Replaced by pull request #25103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants