Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc block to use correct element order #25175

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Fix doc block to use correct element order #25175

merged 1 commit into from
Jun 11, 2019

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 11, 2019

Doc blocks should generally be in this order:

  • Short description
  • Long description
  • Tags (order specified in coding standards validators)

The doc block for JGithubPackageData is in the wrong order, which results in incorrect output when parsing the doc blocks for the API documentation, see https://api.joomla.org/cms-3/deprecated.html#joomla/github/package/data.php and https://api.joomla.org/cms-3/classes/JGithubPackageData.html (the long description for the deprecation is actually the class' description). Putting things in the right order will ensure the parser correctly handles this file.

@HLeithner HLeithner merged commit ce3cf03 into joomla:staging Jun 11, 2019
@HLeithner
Copy link
Member

thx

@HLeithner HLeithner added this to the Joomla 3.9.8 milestone Jun 11, 2019
@mbabker mbabker deleted the fix-github-doc branch June 11, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants