[4.0] [com_content] [wip] convert to prepared statement #25179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
| @@ -50,6 +51,7 @@ public function association($articleid) | |||
| } | |||
|
|
|||
| // Get the associated menu items | |||
| $associations = array_values($associations); | |||
| $db = Factory::getDbo(); | |||
| $query = $db->getQuery(true) | |||
| ->select('c.*') | |||
Quy
reviewed
Jun 11, 2019
| @@ -171,13 +181,13 @@ public function getItem($pk = null) | |||
| { | |||
| throw new \Exception(Text::_('COM_CONTENT_ERROR_ARTICLE_NOT_FOUND'), 404); | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
yes i wasn't able to understand what's the meaning of that if, and plus testing work well without
any help ?
Quy
reviewed
Jun 11, 2019
Quy
reviewed
Jun 11, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
ghost
changed the title
Quy
reviewed
Jun 13, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
|
@alikon it would be cool if can bring this PR back. |
|
re-opened as requested, but it will conflict with #25760 |
|
sorry but too much changes since it was opened,or i'm a git dumb, but ,i cannot manage it, better to start from scratch with a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
use prepared statement for SQL
Testing Instructions
test com_content
Expected result
should work as before
Actual result
N/A