Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include user.css in error page protostar #25416

Merged
merged 2 commits into from Jul 20, 2019

Conversation

HLeithner
Copy link
Member

Pull Request for Issue #25286

Summary of Changes

Load user.css on protostar error page on if needed.

Testing Instructions

create a user.css in the css folder of protostar
trigger a 404 error page

Expected result

user.css gets loaded

Actual result

user.css not loaded

@Quy
Copy link
Contributor

Quy commented Jul 3, 2019

I have tested this item ✅ successfully on 9689130


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25416.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jul 3, 2019

It should be the last CSS file loaded.

@Quy
Copy link
Contributor

Quy commented Jul 3, 2019

I have tested this item ✅ successfully on 62ff495


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25416.

@uGE70
Copy link

uGE70 commented Jul 3, 2019

I have tested this item ✅ successfully on 62ff495

user.css is included in error page if there's user.css file in css folder
user.css not included if there's no user.css file.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25416.

@alikon
Copy link
Contributor

alikon commented Jul 3, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25416.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 3, 2019
@roland-d roland-d added this to the Joomla! 3.9.11 milestone Jul 20, 2019
@roland-d roland-d merged commit bcad92e into joomla:staging Jul 20, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 20, 2019
@HLeithner HLeithner deleted the user-css-error-page branch March 29, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants