[4.0] Double translation of template preview button #25821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text for the button was being translated twice To test enable language debug Before this PR the button will display as `??**COM_TEMPLATES_BUTTON_PREVIEW**??` After the PR it will be correctly displayed as `**COM_TEMPLATES_BUTTON_PREVIEW**`
brianteeman
changed the title
brianteeman
changed the title
|
I have tested this item ✅ successfully on 52e7887
|
|
I have tested this item ✅ successfully on 52e7887 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25821. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25821. |
|
Thanks! |
|
Thanks - now if only I could work out how to fix the change actions button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text for the template preview button was being translated twice
To test enable language debug
Before this PR the button will display as
??**COM_TEMPLATES_BUTTON_PREVIEW**??After the PR it will be correctly displayed as
**COM_TEMPLATES_BUTTON_PREVIEW**