Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout Redirection Page is not working #25941

Open
itxchandan opened this issue Aug 20, 2019 · 24 comments
Open

Logout Redirection Page is not working #25941

itxchandan opened this issue Aug 20, 2019 · 24 comments

Comments

@itxchandan
Copy link

Steps to reproduce the issue

Logout Redirection Page "Default" view is not working.

According to tooltip = The default is to stay on the same page.
image

Expected result

Stay on the same page.

Actual result

Redirect to homepage from Default view.

@ghost
Copy link

ghost commented Aug 20, 2019

Which Joomla-Version? There is a Reason why you are asked for "System Information".

@infograf768
Copy link
Member

  1. This screenshot has nothing to do with J 3.x or J4.
  2. In a normal j3 environment we first get a page containing only a Logout button. But therafter we are redirected. If nothing is entered in the Menu Item Logout Redirect or Logout Redirect fields, then the default page can't be the logout view and therefore displays the Home Page.
  3. I agree that the tip is wrong

@itxchandan
Copy link
Author

Joomla V3.9.11

@HLeithner
Copy link
Member

@chandanndeep that doesn't look like a core menu item. can you show us the details tab?

@simbus82
Copy link
Contributor

simbus82 commented Aug 20, 2019

@infograf768 @HLeithner
It's the menu voice "Logout" under "Users" section in "menu voice type" and it's a core element of Joomla.

image

@chandanndeep Is the "System - Logout" plugin enabled or disabled?

If it is active, it overrides the setting of the menu item and always redirects to the home.
I don't know if this is the intended functionality, a warning should be shown ...

@brianteeman
Copy link
Contributor

@HLeithner its the standard logout page! The user just has several plugins installed which add extra tabs

@HLeithner
Copy link
Member

Oh ok I found it, thx @simbus82
funy the german translation is completely different.

@HLeithner
Copy link
Member

The description has been changed by @infograf768 in PR #12337 but I don't see a functional change in this pr maybe I didn't see a reference to a code change?

In my opinion the description is wrong and should be changed back to the original text if there wars no intention to change this behavior in j3.7

@simbus82
Copy link
Contributor

simbus82 commented Aug 20, 2019

Oh ok I found it, thx @simbus82
funy the german translation is completely different.

I was also in doubt, I changed from Italian to English and found it ;-)
About the PR #12337, am I wrong or is it related to the module and not to the menu item?

@infograf768
Copy link
Member

@HLeithner
In fact I did not change the part concerned i.e. redirection to the same page.
That was and is still wrong. We should keep the rest of my changes and just modify that part IMHO.

@brianteeman
Copy link
Contributor

@simbus82 its both
@HLeithner the change in the string was really just to account for the fact that the menu selection was no longer in a dropdown

@brianteeman
Copy link
Contributor

Also dont forget that the string is also used for the module and not just the menu item where the behaviour may be different

@infograf768
Copy link
Member

Also dont forget that the string is also used for the module and not just the menu item where the behaviour may be different

Not that I am aware of.
The login module uses:
MOD_LOGIN_FIELD_LOGIN_REDIRECTURL_DESC
MOD_LOGIN_FIELD_LOGOUT_REDIRECTURL_DESC

@HLeithner
Copy link
Member

change has been done in this commit: 463bbb6#diff-7bead94ab2f4003deaee80abfddcf323L206

From "default" to "same" which is not the same ;-)

anyway so we should change this back to the correct value.

@infograf768
Copy link
Member

lol, indeed. Different from the module indeed.

@infograf768
Copy link
Member

Anyone makes the patch?

@brianteeman
Copy link
Contributor

Also dont forget that the string is also used for the module and not just the menu item where the behaviour may be different

Sorry if I wasnt clear (typing on my phone). The module strings were chan ged in the same PR that Harald linked to and they will be different to the component behaviour

@HLeithner
Copy link
Member

I will make the pr.

@HLeithner
Copy link
Member

Closing for PR #25946

thx all for the help.

@simbus82
Copy link
Contributor

simbus82 commented Aug 20, 2019

Sorry guys but... i have tested it before.

Is the "System - Logout" plugin enabled or disabled?
If it is active, it overrides the setting of the menu item and always redirects to the home.
I don't know if this is the intended functionality, a warning should be shown ..."

If this plugin is disabled, the menu voice with Logout Redirection Page set to "Default" works well, as the expected behaviour.

@HLeithner
Copy link
Member

Based on the source of system - logout it would only redirect you to the main page if the current page is not accessible by the current user. Which is no user if you hit the logout button.

But if you set a redirect the redirect should be executed before system - logout get called to redirect you...

are you sure the page you are redirecting to has access level public? also the component takes the return parameter and should redirect you to the url (menu item) you set. if none is set it redirects you to the default page.

Or I misinterpret something in the source

@simbus82
Copy link
Contributor

I have do this test, i have created a menu voice "logout" with same settings as @chandanndeep.
Example with Plugin ON
I'm logged-in and i'm browsing around. Now i'm in the public url www.mysite/page-public.
Then I see a menu voice called "logout", i click it: i'm redirected to Home Page.
This behaviour is wrong most of the times, because broke the User Experience.

Example with Plugin OFF
I'm logged-in and i'm browsing around. Now i go to the public url www.mysite/page-public.
Then I see a menu voice called "logout", i click it: i'm redirected to www.mysite/page-public, the same page that i'm visiting.
This behaviour is correct, it's what is expected by user.

Maybe we need only to inform the admin user that the plugin affects this behavior.

@ghost ghost reopened this Sep 13, 2019
@ghost
Copy link

ghost commented Sep 13, 2019

Reopened as #25946 is closed.

@joomdonation
Copy link
Contributor

The issue still happens in J4. Unfortunately, with the way menu logout is implemented, it's quite hard to fix.

@Hackwar Hackwar added the bug label Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants