Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] submenu dashboard module [a11y] #26068

Closed
brianteeman opened this issue Aug 29, 2019 · 5 comments
Closed

[4.0] submenu dashboard module [a11y] #26068

brianteeman opened this issue Aug 29, 2019 · 5 comments

Comments

@brianteeman
Copy link
Contributor

Although the dashboards look like they have a lot of modules they are really mostly one module. This causes an accessibility problem as the cog dropdown is given the id of the module and an id must be unique

Go to the system dashboard on a clean install and all of those blocks are really just the same block and the cog icons in those blocks are all duplicates

@infograf768
Copy link
Member

As explained in another issue, repeating that cog icon is also extremely confusing when adding multiple admin modules in a dashboard.
See #26009 (comment)

@brianteeman
Copy link
Contributor Author

Please stop bikeshedding!!

This issue is about the accessibility and nothing else!!!!!!

@infograf768
Copy link
Member

infograf768 commented Aug 29, 2019

I don't know what you mean by bike shedding. I suppose it is not a nice word.
So cool down please.
It is clear that both issues are related. And it is not trivial.
If one has only one cog per REAL module, I guess the a11y would be easier to solve.

@B3nito
Copy link

B3nito commented Aug 31, 2019

@infograf768 https://www.youtube.com/watch?v=H4NW-Cqh308 I have like this video very much ...

@infograf768
Copy link
Member

This patch removes the cog for dashboards sub items
#26245

We still have a flaw though as the Real submenu Dashboard has no more cog, apparently because of Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants