Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch copy duplicate in chrome and IE as the submit event is triggerd twice #26267

Merged
merged 2 commits into from Sep 13, 2019

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Sep 11, 2019

Pull Request for Issue https://forum.joomla.de/thread/10173-stapelverarbeitung-kopiert-beiträge-doppelt (German)

Summary of Changes

On debugging this issue reported in the forum (germam) I have found out that for some reason chrome and IE run the submit event twice and this page here https://www.the-art-of-web.com/javascript/doublesubmit/ pointed me to try return false; in the onclick handler to stop that from happening. This worked for me.

Testing Instructions

First test

  • Install 3.9.11
  • Login to the backend using chrome or IE 11
  • try to use a batch copy of articles for example
  • apply the patch
  • try again
seccond test
  • install 3.9.11
  • Login to the backend using an browser other than chrome and IE
  • try to use a batch copy of articles for example
  • it should work than expected
  • apply the patch
  • try again
  • it should still work as expected

Expected result

The batch copy only copy it once

Actual result

With chrome and IE the batch copy result into two copys

Documentation Changes Required

none

@ghost ghost changed the title Batch copy dublicate in chrome and IE as the submit event is triggerd twce Batch copy dublicate in chrome and IE as the submit event is triggerd twice Sep 12, 2019
@Harmageddon
Copy link
Contributor

I have tested this item ✅ successfully on c1a9c06

Tested in Chromium 76 (Manjaro Linux) in the following views:

  • Banners
  • Categories (Banners)
  • Contacts
  • Articles
  • Fields
  • Field Groups
  • Menu Items
  • Modules
  • Newsfeeds
  • Redirects
  • Tags
  • Users

I can confirm that the problem existed before applying this patch and has been fixed after.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26267.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on c1a9c06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26267.

@ghost ghost removed the PR-staging label Sep 12, 2019
@ghost
Copy link

ghost commented Sep 12, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 12, 2019
@ghost ghost added the PR-staging label Sep 12, 2019
@zero-24 zero-24 added this to the Joomla! 3.9.12 milestone Sep 13, 2019
@infograf768 infograf768 changed the title Batch copy dublicate in chrome and IE as the submit event is triggerd twice Batch copy duplicate in chrome and IE as the submit event is triggerd twice Sep 13, 2019
@HLeithner HLeithner merged commit ad23aed into joomla:staging Sep 13, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 13, 2019
@HLeithner
Copy link
Member

Thanks for fixing ie bugs.

@simbus82
Copy link
Contributor

I thought I was crazy when I saw my colleagues duplicate the content "twice" using the "batch" ... I didn't imagine it was a bug!
The problem was with Chrome.
Thanks a lot guys!

@zero-24 zero-24 deleted the batch_dublicate branch September 13, 2019 23:58
@zero-24
Copy link
Member Author

zero-24 commented Sep 13, 2019

Thanks for fixing ie bugs.

In this case also a issue that came up in chrome :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants