Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Eliminate some inline js #26617

Merged
merged 1 commit into from Oct 19, 2019
Merged

[4.0] Eliminate some inline js #26617

merged 1 commit into from Oct 19, 2019

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

In Joomla 4 the form submission related script is automated through the class form-validate

Testing Instructions

Go to http://j4.local/administrator/index.php?option=com_privacy&view=requests
Click on the New button
Fill the form and click Save And Close
You will return to the list so click on the newly created line and then on the button invalidate

Everything works...

Expected result

Actual result

Documentation Changes Required

No, cleanup

@CG-68
Copy link

CG-68 commented Oct 19, 2019

All test passed!

@berndkohlen
Copy link

tested and ok

@Quy Quy removed the PR-4.0-dev label Oct 19, 2019
@Quy
Copy link
Contributor

Quy commented Oct 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26617.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 19, 2019
@zero-24
Copy link
Member

zero-24 commented Oct 19, 2019

Merging here thanks to @dgrammatiko and the testers here 👍

@zero-24 zero-24 merged commit 193698a into joomla:4.0-dev Oct 19, 2019
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Oct 19, 2019
@dgrammatiko dgrammatiko deleted the 4.0-dev-com_privacy branch October 19, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants