Radio buttons are not styled when showing forms in modals #26775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate entry .radio.btn-group > label:first-of-type
Removed 2nd occurrence of .btn-group > .btn:first-child, .radio.btn-group > label:first-of-type
When showing forms in modals (for instance), radio buttons are not skinned and are actually partially hidden (because CSS from template.css hides the clickable buttons, only showing the labels). This is the result of the missing template.js, which adds the proper class names to the form elements.
Missing template.js in component.php of Protostar
Get latest Joomla
Refresh of original Joomla repository
|
I have tested this item ✅ successfully on 8abae6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26775. |
1 similar comment
|
I have tested this item ✅ successfully on 8abae6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26775. |
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26775. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26774.
Summary of Changes
Added template.js to component.php in Protostar.
Testing Instructions
Open a form containing radio buttons inside a modal while using Protostar.
(Sorry, I have noticed while testing a commercial extension, therefore I have no example to provide).
What you could try:
Create a contact mail custom field of radio type.
Create a menu item of type 'List contacts in a category'.
Create an override of the com_contacts component (category view).
Modify the link to the contact items in the default_items.php override to force the modals (just for test purposes):
JRoute::_(ContactHelperRoute::getContactRoute($item->slug, $item->catid)).'&tmpl=component'
In the frontend, this will open the contacts into component.php rather than index.php.
Expected result
The radio buttons are styled.
Actual result
The radio buttons are not styled.
Documentation Changes Required
None.