[4.0] Correcting accessibility in sidebar menu #27079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Nov 15, 2019
infograf768
force-pushed
the
4.0_menu_accessibility
branch
from
68a1d49
to
1a7803c
Compare
|
@Quy @brianteeman |
brianteeman
reviewed
Nov 19, 2019
infograf768
force-pushed
the
4.0_menu_accessibility
branch
from
a9bf11a
to
388fe3f
Compare
|
I have tested this item ✅ successfully on daccdf6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27079. |
1 similar comment
|
I have tested this item ✅ successfully on daccdf6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27079. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27079. |
Quy
reviewed
Nov 19, 2019
| @@ -36,10 +37,10 @@ MOD_MENU_COM_PRIVACY_REQUESTS="Requests" | |||
| MOD_MENU_COM_TEMPLATES_SUBMENU_STYLES="Styles" | |||
| MOD_MENU_COM_TEMPLATES_SUBMENU_TEMPLATES="Templates" | |||
| MOD_MENU_COM_USERS="Users" | |||
| MOD_MENU_COM_USERS_ADD_GROUP="Add New Group" | |||
| MOD_MENU_COM_USERS_ADD_LEVEL="Add New Access Level" | |||
| MOD_MENU_COM_USERS_ADD_GROUP="Add Group" | |||
There was a problem hiding this comment.
Please confirm that these 2 strings are not used.
There was a problem hiding this comment.
They are not used for the moment, but they could if we add some quicktasks in the presets.
To be discussed in another Issue/PR imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #27045 (comment)
Summary of Changes
Using specific lang strings when adding module and menu item
Testing Instructions
Look at source around sr-only for the modules and menus wether using alternate or default preset in admin menu