Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove duplicate class for monochrome settings #27145

Merged
merged 1 commit into from Nov 25, 2019

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Nov 24, 2019

Summary of Changes

Remove duplicate class when monochrome template setting and accessibility setting are enabled.

Testing Instructions

Code review

Expected result

<body class="admin com_templates view-style layout-edit task-display monochrome">

Actual result

<body class="admin com_templates view-style layout-edit task-display monochrome monochrome">

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 8957a86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27145.

@brianteeman
Copy link
Contributor

Can you update the title please to something more meaningful as it will be the commit message

@Quy Quy changed the title [4.0] Simplify code [4.0] Remove duplicate class for monochrome settings Nov 24, 2019
@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on 8957a86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27145.

@SharkyKZ
Copy link
Contributor

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27145.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 25, 2019
@wilsonge wilsonge merged commit a18e5e6 into joomla:4.0-dev Nov 25, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 25, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Nov 25, 2019
@Quy Quy deleted the monochrome branch November 25, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants