Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [plg_system_cache] Fix debug with page caching enabled #27166

Merged
merged 6 commits into from
Feb 6, 2020
Merged

[4.0] [plg_system_cache] Fix debug with page caching enabled #27166

merged 6 commits into from
Feb 6, 2020

Conversation

SharkyKZ
Copy link
Contributor

Summary of Changes

Loads a document into application for plugins that expect it to be available in onAfterRespond event.

Testing Instructions

Enable Debug System option in Global Configuration.
Enable System - Page Cache plugin.
Enable System - Debug plugin.
As a guest view the same page in frontend at least twice.

Expected result

No errors.

Actual result

Call to a member function getType() on null

Documentation Changes Required

Page caching and onPageCacheSetCaching event moved from onAfterInitialise to onAfterRoute.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 2e3ab6f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27166.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 9b215ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27166.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Feb 5, 2020

I have tested this item ✅ successfully on 9b215ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27166.

@Quy
Copy link
Contributor

Quy commented Feb 5, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27166.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 5, 2020
@rdeutz rdeutz merged commit 3b9fa84 into joomla:4.0-dev Feb 6, 2020
@rdeutz rdeutz added this to the Joomla 4.0 milestone Feb 6, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 6, 2020
@SharkyKZ SharkyKZ deleted the j4/cleanup/plg_system_cache branch February 6, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants