Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Menu item module assignment Unpublished Modules issue #27491

Closed
infograf768 opened this issue Jan 12, 2020 · 4 comments
Closed

[4.0] Menu item module assignment Unpublished Modules issue #27491

infograf768 opened this issue Jan 12, 2020 · 4 comments

Comments

@infograf768
Copy link
Member

Make sure one of your site modules is unpublished.
Edit a menu item, switch to Module Assignment tab.
Look at the module which is unpublished. There is a No badge.
Select Hide for the Unpublished modules field

Result: the module is correctly hidden.

Then switch to Show

Result, the module row displays but is empty

modulesassignment

@infograf768
Copy link
Member Author

Same issue for Unassigned Modules

js code is

      list.forEach((item) => {
        item.classList.add('table-row');
      });

@infograf768
Copy link
Member Author

I think I found out. Testing now locally

@infograf768
Copy link
Member Author

Solution is adding
item.classList.remove('hidden');

for assigned1 and published1 in the js

Will make patch after #27455 is merged

@infograf768
Copy link
Member Author

Please test #27492
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants