Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for folder size on mobile re issue #27537 #27573

Closed
wants to merge 2 commits into from
Closed

Fix for folder size on mobile re issue #27537 #27573

wants to merge 2 commits into from

Conversation

AndyGaskell
Copy link
Contributor

@AndyGaskell AndyGaskell commented Jan 19, 2020

Fix for the UI size issue described in
[4.0] [backend-template] Media Manager unusable on mobile #27537

Pull Request for Issue # .

Summary of Changes

Small CSS / SCSS change to make the folder icon in the media manager work better on mobile screen size

Testing Instructions

  1. Use small window or mobile device, like 375 x 667 pixels (iPhone6)
  2. Login to admin and go administrator
  3. Go to media manager
  4. Look at size of folder

Also repeat on other screen sizes

Expected result

Should be able to click on the folders

Actual result

Can't click on the folders because they're too big and overlap each other

Documentation Changes Required

None

Further notes...

Screen grab of issue...
Screen Shot 2020-01-19 at 18 21 05

Screen grab after fix...
Screen Shot 2020-01-19 at 18 20 50

Fix for the UI size issue described in
[4.0] [backend-template] Media Manager unusable on mobile #27537
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 19, 2020
@Quy
Copy link
Contributor

Quy commented Jan 19, 2020

A side effect is that the folder icon is larger on desktop.

27573

@AndyGaskell
Copy link
Contributor Author

Thanks for testing @Quy yea, that probably doesn't look ideal. What do you think?

I'll can try a different fix, using a media query in the css.

@C-Lodder
Copy link
Member

It's not just the font size that need tweaking. The whole things need to be worked on, on mobile.

  • There doesn't appear to be any form of proper stacking.
  • The search box underlaps the container
  • The zoom in/out and other icons are missing, due to underlapping.

@AndyGaskell
Copy link
Contributor Author

Hi @C-Lodder

Yea, I agree really, I think I was kinda tip-toeing around this a bit as I'm not so familiar with this bit of front-end code, well, front end code generally, too much time writing APIs last few years. It's coming back to me though 🤓

I'll have another go over it all in a more wholistic way, starting with pencil and paper. Though that'll probably be next week.

Thanks for your input and creating this issue.

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jan 27, 2020
@Quy
Copy link
Contributor

Quy commented Feb 9, 2020

Closing for now as not proper fix. Thanks.

@Quy Quy closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants