Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Cast XML element as string #28006

Merged
merged 2 commits into from
Feb 22, 2020
Merged

[4.0] Cast XML element as string #28006

merged 2 commits into from
Feb 22, 2020

Conversation

SharkyKZ
Copy link
Contributor

Summary of Changes

Missed these in #27194. Casts XML element as string so strict comparison works properly.

Testing Instructions

Code review.
Or edit System - SEF plugin. In canonical domain field enter a URL without protocol (e.g. localhost).

Expected result

Value saved as http://localhost.

Actual result

Saving fails with error:

Invalid URL: URL schema is missing in localhost. Please add one of the following at the beginning: http, https, ftp, ftps, gopher, mailto, news, prospero, telnet, rlogin, sftp, tn3270, wais, mid, cid, nntp, tel, urn, ldap, file, fax, modem, git.

Documentation Changes Required

No.

@Quy
Copy link
Contributor

Quy commented Feb 21, 2020

I have tested this item ✅ successfully on 62161bf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28006.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 62161bf

Testing of PR is good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28006.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28006.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 21, 2020
@Quy Quy added the PR-4.0-dev label Feb 22, 2020
@rdeutz rdeutz merged commit 9efee51 into joomla:4.0-dev Feb 22, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2020
@Quy Quy added this to the Joomla 4.0 milestone Feb 22, 2020
@SharkyKZ SharkyKZ deleted the j4/typesafe/url-filter branch February 22, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants