Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Cleanup Component Dispatchers #28507

Merged
merged 1 commit into from Mar 30, 2020

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Mar 29, 2020

Summary of Changes

  • Cleans up the dispatchers to use the CMSApplicationInterface rather than the concrete CMSApplication class (the module dispatcher was incorrectly using it already but after [4.0] Add getLanguage to application interface and cleanup console/cli apps #28506 is merged all will be fine there).
  • Removes duplicated declared properties in ApiDispatcher that were left over from earlier incarnations of the class. Cleaned up a doc block in ApiDispatcher too to correctly reflect why we override the method.

Testing Instructions

Check the Joomla components still load correctly. No changes expected in the interface

Documentation Changes Required

Nothing new - docs will be added when the dispatcher class itself is documented

@wilsonge wilsonge force-pushed the feature/dispatcher-interface branch from 5315a66 to f0999d4 Compare March 29, 2020 23:44
@wilsonge wilsonge marked this pull request as ready for review March 29, 2020 23:45
@wilsonge wilsonge merged commit b4e270a into joomla:4.0-dev Mar 30, 2020
@wilsonge wilsonge deleted the feature/dispatcher-interface branch March 30, 2020 09:21
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants