Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Custom Element styling #28626

Open
ciar4n opened this issue Apr 10, 2020 · 6 comments
Open

[4.0] Custom Element styling #28626

ciar4n opened this issue Apr 10, 2020 · 6 comments

Comments

@ciar4n
Copy link
Contributor

ciar4n commented Apr 10, 2020

Elements like alerts appear to import styling upstream from the custom-element repo and then proceed to mostly override that styling locally. The result is at least twice as much CSS as is required.

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss#L12

Styling should be applied upstream on the custom-elements repo OR remove the import and style locally.. not both.

@brianteeman
Copy link
Contributor

agree 100% it should be one or the other and not both

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 10, 2020

One option.... #28627

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 10, 2020

Turns out there is 2 different styles of alert. The second style overriding the first depending on where it is rendered. 😒

So regarding the alerts, it is not as bad but still weird.

@wilsonge
Copy link
Contributor

Do we really need two styles of alert. I have to admit the stuff in the sample data install that is inline does look a bit weird. But feels like there should be a better way of handling it somehow

@brianteeman
Copy link
Contributor

Well we do need inline alerts to satisfy #27391

@Hackwar Hackwar added the bug label Feb 21, 2023
@brianteeman
Copy link
Contributor

Is this a duplicate of #22842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants