New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Custom Element styling #28626
Comments
agree 100% it should be one or the other and not both |
|
Turns out there is 2 different styles of alert. The second style overriding the first depending on where it is rendered. 😒 So regarding the alerts, it is not as bad but still weird. |
Do we really need two styles of alert. I have to admit the stuff in the sample data install that is inline does look a bit weird. But feels like there should be a better way of handling it somehow |
Well we do need inline alerts to satisfy #27391 |
Is this a duplicate of #22842 |
Elements like alerts appear to import styling upstream from the custom-element repo and then proceed to mostly override that styling locally. The result is at least twice as much CSS as is required.
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss#L12
Styling should be applied upstream on the custom-elements repo OR remove the import and style locally.. not both.
The text was updated successfully, but these errors were encountered: